Re: [PATCH] pg_isready (was: [WIP] pg_ping utility)

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Phil Sorber <phil(at)omniti(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] pg_isready (was: [WIP] pg_ping utility)
Date: 2013-02-04 11:49:49
Message-ID: 20130204114949.GB17549@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Feb 2, 2013 at 09:55:29PM -0500, Phil Sorber wrote:
> >>> I think that output is important as do others up thread. I think it'd
> >>> be simpler to just disable dbname's ability to double as conninfo. If
> >>> we are looking for easy, that is.
> >>>
> >>> I don't mind duplicating the behavior from conninfo_array_parse() or
> >>> uri-regress.c either. I can just put a comment that at some point in
> >>> the future we should add a libpq interface for it.
> >>
> >> I suggest duplicate the code for 9.3, and submit a patch to refactor
> >> into a new libpq function for CF2013-next. If the patch is simple
> >> enough, we can consider putting it into 9.3.
> >
> > Agreed.
> >
> > Regards,
> >
> > --
> > Fujii Masao
>
> OK, here is the patch that handles the connection string in dbname.
> I'll post the other patch under a different posting because I am sure
> it will get plenty of debate on it's own.

If we could run pg_isready on the patch, it would tell us if the patch
is ready. Consider this a feature request. ;-)

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ali Dar 2013-02-04 12:48:44 Re: missing rename support
Previous Message Josh Berkus 2013-02-04 11:00:17 Re: Streaming-only cascading replica won't come up without writes on the master