Re: pgsql: Fill tuple before HeapSatisfiesHOTAndKeyUpdate

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fill tuple before HeapSatisfiesHOTAndKeyUpdate
Date: 2013-02-01 17:25:04
Message-ID: 20130201172504.GB2371@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Feb 1, 2013 at 01:50:02PM +0000, Álvaro Herrera wrote:
> Fill tuple before HeapSatisfiesHOTAndKeyUpdate
>
> Failing to do this results in almost all updates to system catalogs
> being non-HOT updates, because the OID column would differ (not having
> been set for the new tuple), which is an indexed column.
>
> While at it, make sure to set the tableoid early in both old and new
> tuples as well. This isn't of much consequence, since that column is
> seldom (never?) indexed.
>
> Report and patch from Andres Freund.

Was this a new bug in 9.3?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2013-02-01 17:29:36 Re: pgsql: Fill tuple before HeapSatisfiesHOTAndKeyUpdate
Previous Message Alvaro Herrera 2013-02-01 15:14:11 pgsql: Fix typo in freeze_table_age implementation