From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | james(at)illusorystudios(dot)com |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: [BUGS] BUG #7515: DROP TABLE IF EXISTS fails if schema does not exist |
Date: | 2013-01-25 01:45:20 |
Message-ID: | 20130125014520.GO21914@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Sun, Sep 2, 2012 at 05:40:54PM +0000, james(at)illusorystudios(dot)com wrote:
> The following bug has been logged on the website:
>
> Bug reference: 7515
> Logged by: James Bellinger
> Email address: james(at)illusorystudios(dot)com
> PostgreSQL version: 9.1.5
> Operating system: Ubuntu Linux 12.04 Server
> Description:
>
> If the table being referenced has a schema in its name, and the schema does
> not exist, DROP TABLE IF EXISTS will have an ERROR instead of a NOTICE.
>
> So for instance,
> DROP TABLE IF EXISTS bar;
> This is a NOTICE if bar does not exist.
>
> DROP TABLE IF EXISTS foo.bar;
> This is an ERROR if foo does not exist, even though that implies bar does
> not exist which means it should be a NOTICE.
>
> Saw this because it was making a drop/recreate transaction fail on me, after
> I changed some code to use a schema.
I looked at this bug report from September. The problem is that
LookupExplicitNamespace() doesn't have a missing_ok parameter, even
though get_namespace_oid(), which it calls, does. By adding a
missing_ok parameter and passing it cleanly, I fixed the problem:
test=> DROP TABLE IF EXISTS foo.bar;
NOTICE: table "bar" does not exist, skipping
DROP TABLE
Patch attached.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
Attachment | Content-Type | Size |
---|---|---|
drop_table.diff | text/x-diff | 15.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2013-01-25 06:35:08 | Re: BUG #6528: pglesslog still referenced in docs, but no 9.1 support |
Previous Message | Mark Kirkwood | 2013-01-25 00:56:41 | Re: PL/R Median Busts Commit (Postgres 9.1.6 + plr 8.3.0.13 on Ubuntu 12.10 64 bit) |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2013-01-25 01:48:37 | Re: COPY FREEZE has no warning |
Previous Message | Craig Ringer | 2013-01-25 01:44:28 | Re: Strange Windows problem, lock_timeout test request |