| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | pg_upgrade and system() return value |
| Date: | 2013-01-20 02:46:32 |
| Message-ID: | 20130120024632.GA24542@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Can someone comment on the attached patch? pg_upgrade was testing if
system() returned a non-zero value, while I am thinking I should be
adjusting system()'s return value with WEXITSTATUS().
Is there any possible bug in back branches just compariing system()'s
turn value to non-zero without calling WEXITSTATUS()? I never saw a bug
related to this. I am thinking of applying this just to git head.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| Attachment | Content-Type | Size |
|---|---|---|
| pg_upgrade.diff | text/x-diff | 390 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2013-01-20 02:56:48 | Re: BUG #7815: Upgrading PostgreSQL from 9.1 to 9.2 with pg_upgrade/postgreql-setup fails - invalid status retrieve |
| Previous Message | Stephen Frost | 2013-01-20 02:40:19 | Re: Identity projection |