Re: logical changeset generation v4

Andres Freund wrote:
> On 2013-01-15 01:00:00 -0300, Alvaro Herrera wrote:
> > Andres Freund wrote:
> >
> > I've been giving a couple of these parts a look. In particular
> >
> > > [03] Split out xlog reading into its own module called xlogreader
> >
> > Cleaned this one up a bit last week. I will polish it some more,
> > publish for some final comments, and commit.
>
> I have some smaller bugfixes in my current version that you probably
> don't have yet (on grounds of being fixed this weekend)... So we need to
> be a bit careful not too loose those.

Sure. Do you have them as individual commits? I'm assuming you rebased
the tree. Maybe in your reflog? IIRC I also have at least one minor
bug fix.

> > > Second, I don't think the test_logical_replication functions should live
> > > in core as they shouldn't be used for a production replication scenario
> > > (causes longrunning transactions, requires polling) , but I have failed
> > > to find a neat way to include a contrib extension in the plain
> > > regression tests.
> >
> > I think this would work if you make a "stamp" file in the contrib
> > module, similar to how doc/src/sgml uses those.
>
> I tried that, the problem is not the building itself but getting it
> installed into the temporary installation...

Oh, hm. Maybe the contrib module's make installcheck, then?

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services