Re: Re: [PATCH 1/5] Centralize Assert* macros into c.h so its common between backend/frontend

On 2013-01-08 17:36:19 -0300, Alvaro Herrera wrote:
> Andres Freund wrote:
> > On 2013-01-08 14:35:12 -0500, Tom Lane wrote:
> > > Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > > > On 2013-01-08 14:25:06 -0500, Tom Lane wrote:
> > > >> This patch seems unnecessary given that we already put a version of Assert()
> > > >> into postgres_fe.h.
> > >
> > > > The problem is that some (including existing) pieces of code need to
> > > > include postgres.h itself, those can't easily include postgres_fe.h as
> > > > well without getting into problems with redefinitions.
> > >
> > > There is no place, anywhere, that should be including both. So I don't
> > > see the problem.
> >
> > Sorry, misremembered the problem somewhat. The problem is that code that
> > includes postgres.h atm ends up with ExceptionalCondition() et
> > al. declared even if FRONTEND is defined. So if anything uses an assert
> > you need to provide wrappers for those which seems nasty. If they are
> > provided centrally and check for FRONTEND that problem doesn't exist.
>
> I think the right fix here is to fix things so that postgres.h is not
> necessary. How hard is that? Maybe it just requires some more
> reshuffling of xlog headers.

I don't really think thats realistic. Think the rmgrdesc/* files and
xlogreader.c itself...

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services