Re: PATCH: optimized DROP of multiple tables within a transaction

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tomas Vondra <tv(at)fuzzy(dot)cz>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: PATCH: optimized DROP of multiple tables within a transaction
Date: 2013-01-04 17:08:35
Message-ID: 20130104170835.GA9191@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 24, 2012 at 02:41:37AM +0100, Tomas Vondra wrote:

> + SMgrRelation *srels = palloc(sizeof(SMgrRelation));
> + int nrels = 0,
> + i = 0,
> + maxrels = 1;

maxrels=1 is not good -- too much palloc traffic. I'd make it start at,
say, 8 instead.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2013-01-04 17:10:15 Re: lock AccessShareLock on object 0/1260/0 is already held
Previous Message Tom Lane 2013-01-04 16:54:42 Re: lock AccessShareLock on object 0/1260/0 is already held