Re: Patch for checking file parameters to psql before password prompt

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
Cc: Alastair Turner <bell(at)ctrlf5(dot)co(dot)za>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patch for checking file parameters to psql before password prompt
Date: 2012-12-29 20:10:00
Message-ID: 20121229201000.GC16126@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Josh,

* Josh Kupershmidt (schmiddy(at)gmail(dot)com) wrote:
> I assume you meant "-L" instead of "-l" here for specifying psql's log
> file. I don't think that the inability to write to psql's log file
> should be treated as a fatal error, especially since it is not treated
> as such by the current code:

I disagree- if we're being asked to log or to send output somewhere, we
should error out if we're unable to do so. Consider doing that from the
shell:

sfrost(at)beorn:~$ psql > /bin/qq
bash: /bin/qq: Permission denied
sfrost(at)beorn:~$

Thanks,

Stephen

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2012-12-29 20:18:07 Re: enhanced error fields
Previous Message Pavel Stehule 2012-12-29 20:07:01 Re: enhanced error fields