Re: My first patch! (to \df output)

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Jon Erdman <postgresql(at)thewickedtribe(dot)net>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: My first patch! (to \df output)
Date: 2012-12-29 18:56:09
Message-ID: 20121229185609.GV16126@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Jon Erdman (postgresql(at)thewickedtribe(dot)net) wrote:
> Oops! Here it is in the proper diff format. I didn't have my env set up correctly :(

No biggie, and to get the bike-shedding started, I don't really like the
column name or the values.. :) I feel like something clearer would be
"Runs_As" with "caller" or "owner".. Saying "Security" makes me think
of ACLs more than what user ID the function runs as, to be honest.

Looking at the actual patch itself, it looks like you have some
unecessary whitespace changes included..?

Thanks!

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gavin Flower 2012-12-29 18:59:04 Re: inconsistent time zone formats in log
Previous Message Pavel Stehule 2012-12-29 18:53:51 Re: proposal: a width specification for s specifier (format function), fix behave when positional and ordered placeholders are used