Re: PITR potentially broken in 9.2

On 2012-11-28 15:37:38 +0200, Heikki Linnakangas wrote:
> On 28.11.2012 15:26, Andres Freund wrote:
> >Hm. Are you sure its actually reading your backup file? Its hard to say
> >without DEBUG1 output but I would tentatively say its not reading it at
> >all because the the "redo starts at ..." message indicates its not using
> >the checkpoint location from the backup file.
>
> By backup file, you mean the backup history file? Since 9.0, recovery does
> not read the backup history file, it's for informational/debugging purposes
> only. All the information recovery needs is in the backup_label, and an
> end-of-backup WAL record marks the location where pg_stop_backup() was
> called, ie. how far the WAL must be replayed for the backup to be
> consistent.
>

I mean the label read by read_backup_label(). Jeff's mail indicated it
had CHECKPOINT_LOCATION at 1/188D8120 but redo started at 1/CD89E48.

>Can you reproduce the issue? If so, can you give an exact guide? If not,
> >do you still have the datadir et al. from above?

> I just committed a fix for this, but if you can, it would still be nice if
> you could double-check that it now really works.

Yuck. Too bad that that got in.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services