Re: Tweaking ResolveNew's API

On Thu, Nov 08, 2012 at 02:35:34PM -0500, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > Tom Lane wrote:
> >> A possible objection to this is that most C compilers wouldn't complain
> >> if a call site is still trying to use the old convention of passing a
> >> CmdType value. In the core code, there are only four call sites and
> >> three are in rewriteHandler.c itself, so this isn't much of a problem
> >> --- but if there's any third-party code such as FDWs that's trying to
> >> make use of this function for querytree manipulation, there'd be a risk
> >> of failing to notice the need to update the call.
>
> > Failing to notice such changes is easy if the compiler doesn't even
> > issue a warning, so *some* way to have old code fail (even better if
> > it's a hard error and not just a warning) would be nice. I'm not sure I
> > have useful suggestions on how to do it, though, just a +1 to doing it.
>
> Actually, it occurs to me that there's a really easy way to get the
> result: let's just rename the function. ResolveNew isn't an amazingly
> mnemonic name anyway. How about ReplaceVarsFromTargetList?

+1 for descriptive names :)

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate