| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: [PATCH 3/8] Add support for a generic wal reading facility dubbed XLogReader |
| Date: | 2012-09-17 10:01:41 |
| Message-ID: | 201209171201.41342.andres@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Monday, September 17, 2012 11:07:28 AM Andres Freund wrote:
> On Monday, September 17, 2012 10:30:35 AM Heikki Linnakangas wrote:
> > On 17.09.2012 11:12, Andres Freund wrote:
> > > On Monday, September 17, 2012 09:40:17 AM Heikki Linnakangas wrote:
> > > If you don't want the capability to forward/filter the data and read
> > > partial data without regard for record constraints/buffering your patch
> > > seems to be quite a good start. It misses xlogreader.h though...
> >
> > Ah sorry, patch with xlogreader.h attached.
>
> Will look at it in a second.
It seems we would need one additional callback for both approaches like:
->error(severity, format, ...)
For both to avoid having to draw in elog.c.
Otherwise it looks sensible although it has a more minimal approach (which
might or might not be a good thing). The one thing I definitely like is that
nearly all of it is tried and true code...
Greetings,
Andres
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2012-09-17 10:52:32 | Re: [PATCH 3/8] Add support for a generic wal reading facility dubbed XLogReader |
| Previous Message | Andres Freund | 2012-09-17 09:07:28 | Re: [PATCH 3/8] Add support for a generic wal reading facility dubbed XLogReader |