From: | Noah Misch <noah(at)leadboat(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: missing semicolon at end of psql files |
Date: | 2012-09-13 12:35:48 |
Message-ID: | 20120913123548.GC12235@tornado.leadboat.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Sep 12, 2012 at 03:20:24PM -0400, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > I was surprised to find that psql -f file.sql with a file such as this
> > select 1;
> > select 2
>
> > executes both commands even though the second one is not terminated.
> I'm a little dubious about changing this behavior. As you say, it's
> not like we're consistent about requiring semicolons everywhere, and
> frankly I think the argument about truncated files is specious.
> I've never heard of that actually happening to anybody.
>
> What would you have it do instead? Throw an error? Silently drop
> the last command (which would be the same thing, if nobody was paying
> attention to the error message)? I think the compatibility lossage
> from either would outweigh the benefit.
Fully agreed.
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2012-09-13 13:18:43 | Re: remove dead ports? |
Previous Message | Shigeru HANADA | 2012-09-13 09:31:52 | Re: Move postgresql_fdw_validator into dblink |