From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Hannu Krosing <hannu(at)2ndquadrant(dot)com> |
Subject: | Re: plperl sigfpe reset can crash the server |
Date: | 2012-08-25 05:57:50 |
Message-ID: | 201208250757.50596.andres@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Saturday, August 25, 2012 06:38:09 AM Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > Doing a pqsignal(SIGFPE, FloatExceptionHandler) after PERL_SYS_INIT3
> > seems to work. Is that acceptable?
>
> Surely that's breaking perl's expectations, to more or less the same
> degree they're breaking ours?
Well. Their expectation simply does not work *at all* because they do
something (setting SIGFPE to SIG_IGN) which is completely ignored on at least
one major platform (x86 linux) for longer than it has git history.
Their math code seems to work around generating such errors, but I find it
rather hard to read (or rather read & understand).
Doing what I proposed admittedly has the issue that we would jump out of perl
code without much ado. I have no idea whats the proper perly way to do so is.
It just seems we should do something...
if (in_perl)
return;
Would be the equivalent of what they want?
Greetings,
Andres
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Florian Weimer | 2012-08-25 07:53:30 | Re: Covering Indexes |
Previous Message | Peter Eisentraut | 2012-08-25 04:52:09 | Re: pg_upgrade's exec_prog() coding improvement |