Re: [COMMITTERS] pgsql: Clean up the #include mess a little.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Ants Aasma <ants(dot)aasma(at)eesti(dot)ee>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Clean up the #include mess a little.
Date: 2012-08-15 22:30:40
Message-ID: 20120815223040.GS25473@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Sep 7, 2011 at 01:20:17AM +0300, Ants Aasma wrote:
> On Tue, Sep 6, 2011 at 10:18 PM, Alvaro Herrera
> <alvherre(at)commandprompt(dot)com> wrote:
> > I wonder what happens if files in the same subdir are grouped in a
> > subgraph.  Is that possible?
>
> Possible, and done. Also added possivility to add .c files to the graph,
> coloring by subdir and possibility exclude nodes from the graph. I didn't yet
> bother to clean up the code - to avoid eye damage, don't look at the source.
>
> Bad news is that it doesn't significantly help readability for the all nodes
> case. See all_with_subgraphs.svgz. It does help for other cases.
> For example parsenodes.h.svgz has the result for
> render_includes.py --select='nodes/parsenodes.h+*-*' --subgraphs
> and execnodes.h.svgz for
> --subgraphs --select='nodes/execnodes.h+*-*'

Should we add this script and instructions to src/tools/pginclude?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2012-08-15 23:02:54 pgsql: Fix rescan logic in nodeCtescan.
Previous Message Bruce Momjian 2012-08-15 20:48:17 pgsql: On second thought, explain why date_trunc("week") on interval va

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-08-15 22:42:51 Re: [BUGS] BUG #6184: Inconsistencies in log messages
Previous Message Merlin Moncure 2012-08-15 22:28:10 Planner avoidance of index only scans for partial indexes