From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Christoph Anton Mitterer <calestyo(at)scientia(dot)net>, pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: BUG #6150: commit_delay should have unit ms |
Date: | 2012-08-14 21:29:40 |
Message-ID: | 20120814212940.GA15578@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Tue, Aug 14, 2012 at 05:26:39PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Opps, turns out the units are microseconds (as pointed out to me by
> > Magnus), and we don't have a microsecond designation in that file, so I
> > reverted that and just added a C comment about why it has no units.
>
> Is it worth adding support for microseconds in there? Not sure.
>
> Technically it wouldn't be very hard, but I seem to recall this was
> discussed before and we were worried about whether people would be
> confused about what "ms" means. Don't know that "us" would be
> universally recognized, either.
Yes, I do remember the discussion. Because commit_delay is so rarely
used, and the only one that uses usec units by default, it didn't seem
to make sense to add documentation for an additional unit.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-08-14 21:30:25 | Re: Possible memory leak/memory issue in pg_dump |
Previous Message | Tom Lane | 2012-08-14 21:26:39 | Re: BUG #6150: commit_delay should have unit ms |