From: | Noah Misch <noah(at)leadboat(dot)com> |
---|---|
To: | Josh Kupershmidt <schmiddy(at)gmail(dot)com> |
Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
Subject: | Re: autocomplete - SELECT fx |
Date: | 2012-07-08 00:43:24 |
Message-ID: | 20120708004324.GA25760@tornado.leadboat.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jul 05, 2012 at 06:43:09PM -0700, Josh Kupershmidt wrote:
> On Mon, Jul 2, 2012 at 1:13 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>
> > I tested Peter's patch and it works well.
>
> I liked it as well. But I'm not sure what should happen with the patch
> now. It seems like it'd be commit-ready with just a tweak or two to
> the query as I noted in my last mail, but Tom did seem opposed[1] to
> the idea in the first thread, and no one else has spoken up recently
> in favor of the idea, so maybe it should just be marked Rejected or
> Returned with Feedback?
I like the patch, as far as it goes. It's the natural addition to the
completions we already offer; compare the simplistic completion after WHERE.
Like Pavel and Robert, I think a delightful implementation of tab completion
for SELECT statements would require radical change.
Thanks,
nm
From | Date | Subject | |
---|---|---|---|
Next Message | Tatsuo Ishii | 2012-07-08 02:10:57 | Re: Patch: add conversion from pg_wchar to multibyte |
Previous Message | Tom Lane | 2012-07-07 21:18:34 | Re: Schema version management |