From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Cc: | Marko Kreen <markokr(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
Subject: | Re: [PATCH 10/16] Introduce the concept that wal has a 'origin' node |
Date: | 2012-06-19 22:01:05 |
Message-ID: | 201206200001.05681.andres@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tuesday, June 19, 2012 10:58:44 PM Marko Kreen wrote:
> On Mon, Jun 18, 2012 at 6:35 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> > On 13 June 2012 19:28, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> >> This adds a new configuration parameter multimaster_node_id which
> >> determines the id used for wal originating in one cluster.
> >
> > Looks good and it seems this aspect at least is commitable in this CF.
> >
> > Design decisions I think we need to review are
> >
> > * Naming of field. I think origin is the right term, borrowing from
> > Slony.
>
> I have not read too deeply here, so maybe I am missing
> some important detail here, but idea that users need
> to coordinate a integer config parameter globally does not
> sound too attractive to me.
>
> Why not limit integers to local storage only and map
> them to string idents on config, UI and transport?
That should be possible. I don't want to go there till we have the base stuff
in but it shouldn't be too hard.
Greetings,
Andres
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-06-19 22:01:55 | Re: use of int4/int32 in C code |
Previous Message | Christopher Browne | 2012-06-19 21:59:36 | Re: [PATCH 10/16] Introduce the concept that wal has a 'origin' node |