From: | Marko Kreen <markokr(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing |
Date: | 2012-03-28 12:46:26 |
Message-ID: | 20120328124626.GA24122@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Wed, Mar 28, 2012 at 08:19:37AM -0400, Robert Haas wrote:
> On Tue, Mar 27, 2012 at 10:10 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> > On Wed, Mar 28, 2012 at 5:17 AM, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
> >> pg_test_timing utility, to measure clock monotonicity and timing cost.
> >
> > When I compiled this, I got a compiler warning. Attached patch
> > silences the warning.
>
> Unfortunately, that *produces* a warning on my machine. Normally, I
> think we handle this using INT64_FORMAT, but the fact that it's %10ld
> here and not just %lld makes that awkward. I guess we maybe need to
> insert some kludgy workaround here - write it into a separate buffer,
> and then blank-pad it, or something like that.
How about: ".. %10" INT64_FORMAT " .. " ?
--
marko
From | Date | Subject | |
---|---|---|---|
Next Message | Marko Kreen | 2012-03-28 12:51:35 | Re: Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing |
Previous Message | Robert Haas | 2012-03-28 12:43:56 | pgsql: pg_basebackup: Error message improvements. |
From | Date | Subject | |
---|---|---|---|
Next Message | Marko Kreen | 2012-03-28 12:51:35 | Re: Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing |
Previous Message | Robert Haas | 2012-03-28 12:44:17 | Re: Improvement of log messages in pg_basebackup |