From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Cc: | Thom Brown <thom(at)linux(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: Command Triggers, patch v11 |
Date: | 2012-03-04 15:50:39 |
Message-ID: | 201203041650.39826.andres@anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On Saturday, March 03, 2012 01:08:33 AM Thom Brown wrote:
> On 2 March 2012 23:33, Thom Brown <thom(at)linux(dot)com> wrote:
> > On 2 March 2012 22:32, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> wrote:
> >>>> test=# CREATE TABLE badname (id int, a int, b text);
> >>>> ERROR: invalid relation name: badname
> >>>> test=# CREATE TABLE badname AS SELECT 1::int id, 1::int a, ''::text b;
> >>>> SELECT 1
> >>>>
> >>>> This doesn't even get picked up by ANY COMMAND.
> >>
> >> I think Andres should add an entry for his patch on the commitfest. Is
> >> it ok?
> >
> > I'll try Andres' patch this weekend while I test yours.
>
> Actually no matter which patch I apply first, they cause the other to
> fail to apply.
Ok, I rebased my patch ontop of dim's current HEAD. There was only one trivial
conflict in tablecmds.h. I had written the patch independently of the command
triggers stuff because I though, and still do, that would make applying it
easier.
Attached are two versions of the patch, one based on command triggers and one
without. Both pass regression tests for me.
Andres
Attachment | Content-Type | Size |
---|---|---|
ctas-01.patch | text/x-patch | 76.7 KB |
ctas-on-command-triggers-01.patch | text/x-patch | 76.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Meskes | 2012-03-04 16:16:06 | Re: ECPG FETCH readahead |
Previous Message | Andrew Dunstan | 2012-03-04 15:45:15 | Re: Patch review for logging hooks (CF 2012-01) |