From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)oss(dot)ntt(dot)co(dot)jp> |
---|---|
To: | markokr(at)gmail(dot)com |
Cc: | greg(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org, mmoncure(at)gmail(dot)com, shigeru(dot)hanada(at)gmail(dot)com |
Subject: | Re: Speed dblink using alternate libpq tuple storage |
Date: | 2012-02-23 10:14:03 |
Message-ID: | 20120223.191403.108379815.horiguchi.kyotaro@oss.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello, this is new version of the patch.
# This patch is based on the commit
# 2bbd88f8f841b01efb073972b60d4dc1ff1f6fd0 @ Feb 13 to avoid the
# compile error caused by undeclared LEAKPROOF in kwlist.h.
> It must free the PGresults that PQgetResult() returns.
I'm sorry. It slipped out of my mind. Add PQclear() for the
return value.
> Also, please fix 2 issues mentined here:
- PQsetRowProcessorErrMsg() now handles msg as const string.
- Changed the order of the parameters of the type PQrowProcessor.
New order is (PGresult *res, PGrowValue *columns, void *params).
# PQsetRowProcessorErrMsg outside of callback is not implemented.
- Documentation and dblink are modified according to the changes
above.
By the way, I would like to ask you one question. What is the
reason why void* should be head or tail of the parameter list?
regards,
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
libpq_rowproc_20120223.patch | text/x-patch | 23.5 KB |
libpq_rowproc_doc_20120223.patch | text/x-patch | 9.5 KB |
dblink_use_rowproc_20120223.patch | text/x-patch | 12.8 KB |
early_exit_20120223.diff | text/x-patch | 2.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2012-02-23 11:08:51 | overriding current_timestamp |
Previous Message | Daniel Farina | 2012-02-23 09:58:44 | pg_stat_statements normalization: re-review |