From: | Lionel Elie Mamane <lionel(at)mamane(dot)lu> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: LibreOffice driver 1: Building libpq with Mozilla LDAP instead of OpenLDAP |
Date: | 2011-12-16 08:35:31 |
Message-ID: | 20111216083531.GA32490@capsaicin.mamane.lu |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Dec 13, 2011 at 11:45:28AM +0100, Magnus Hagander wrote:
> On Tue, Dec 13, 2011 at 11:15, Lionel Elie Mamane <lionel(at)mamane(dot)lu> wrote:
>> LibreOffice can be configured at build-time to use Mozilla LDAP or
>> OpenLDAP. We patched postgresql's configure.in to build libpq with
>> Mozilla LDAP when requested to do so.
>> I'd also be happy to extract from our patch the parts that are
>> relevant for integration in postgresql proper, and massage them into
>> the right modularity / form. Are you interested?
> Please do.
The patch is attached. I got everybody that touched the patch in the
LibreOffice git repo to agree to the PostgreSQL license for the patch.
The changes to tools/msvc are untested since I don't personally have a
Microsoft Windows build environment and LibreOffice uses
src/interfaces/lipq/win32.mak to build libpq.
The patch introduces a preprocessor macro USE_MICROSOFT_LDAP to enable
the Microsoft LDAP part to replace the previously used "#ifdef WIN32",
since one can also use Mozilla LDAP on MS Windows. I found that
cleaner than putting everywhere "#if defined(WIN32) && ! defined(USE_MOZLDAP)".
Except for that, the only change is to the config/build system proper,
to recognise and use the Mozilla LDAP library.
--
Lionel
Attachment | Content-Type | Size |
---|---|---|
postgresql-moz-ldap.patch | text/x-diff | 9.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Lionel Elie Mamane | 2011-12-16 08:37:41 | Re: LibreOffice driver 1: Building libpq with Mozilla LDAP instead of OpenLDAP |
Previous Message | Greg Smith | 2011-12-16 07:13:21 | Re: [PATCH] Caching for stable expressions with constant arguments v3 |