Re: warning in pg_upgrade

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: warning in pg_upgrade
Date: 2011-11-10 18:06:41
Message-ID: 201111101806.pAAI6fl27720@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas wrote:
> On Thu, Nov 3, 2011 at 3:45 PM, Kevin Grittner
> <Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> > "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> >> Untested patch attached for purposes of discussion.
> >
> > I got in a little testing on it -- not only does this patch
> > eliminate the compile-time warning, but if you try to run pg_upgrade
> > when another session has removed your current working directory, you
> > get a reasonable message instead of the program attempting to
> > proceed with undefined (potential garbage) for a working directory.
>
> Committed. Also fixed another compiler warning that popped up for me.

Thanks Kevin and Robert.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Steve Singer 2011-11-10 18:13:10 Re: pg_dump 9.1.1 hanging (collectSecLabels gets 0 labels)
Previous Message Nikhil Sontakke 2011-11-10 16:53:46 Re: Concurrent CREATE TABLE/DROP SCHEMA leaves inconsistent leftovers