| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, Christopher Browne *EXTERN* <cbbrowne(at)gmail(dot)com>, "ktm(at)rice(dot)edu" <ktm(at)rice(dot)edu>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Disable OpenSSL compression |
| Date: | 2011-11-10 02:29:19 |
| Message-ID: | 20111110022919.GC19871@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 09, 2011 at 05:26:14PM -0500, Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > On Wednesday, November 9, 2011, Albe Laurenz wrote:
> >> Is the following proposal acceptable:
> >>
> >> - Add a GUC ssl_compression, defaulting to "on".
> >> - Add a client option "sslcompression" and an environment variable
> >> PGSSLCOMPRESSION, defaulting to "1".
>
> > Seems like the reasonable thing, yes.
>
> A GUC is entirely, completely, 100% the wrong answer. It has no way to
> deal with the fact that some clients may need compression and others
> not.
>
> It should be a client option, full stop. The fact that that will be
> more work to implement does not make "kluge it at the server" the right
> answer.
Assuming the GUC is PGC_BACKEND or better, what is the distinction beyond the
cosmetic "sslcompression=off" vs. "options='-c ssl_compression=off'"?
Does OpenSSL respect changes to this setting during a connection's lifetime? If
so, we could offer a PGC_USERSET GUC, enabling the client to even alternate use
of compression within a single session.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua D. Drake | 2011-11-10 02:35:05 | Re: 9.1.2 ? |
| Previous Message | Robert Haas | 2011-11-10 02:15:55 | Re: 9.1.2 ? |