Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Florian Pflug <fgp(at)phlo(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tim Uckun <timuckun(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.
Date: 2011-10-13 17:09:07
Message-ID: 201110131709.p9DH97j21789@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Tom Lane wrote:
> Florian Pflug <fgp(at)phlo(dot)org> writes:
> > On Jun1, 2011, at 20:28 , Peter Eisentraut wrote:
> >> Well, initdb still succeeds if you give it an invalid locale name. It
> >> warns, but that can easily be missed if initdb is hidden behind a few
> >> other layers. If you then run pg_upgrade, you get a hosed instance.
>
> > Whats the rational behind that behaviour? Wouldn't it be more user-friendly
> > if initdb failed outright? It'd also be consistent with CREATE DATABASE...
>
> I think we were being conservative about whether initdb would get it
> right. Might be time to stiffen our spines a bit, now that the logic
> has been through a few release cycles.

Do we want to revisit this?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Bruce Momjian 2011-10-13 20:31:31 Re: BUG #6254: COPY ... TO .. CSV sometimes doesn't escape strings
Previous Message Andrew Kerr 2011-10-13 16:28:15 BUG #6254: COPY ... TO .. CSV sometimes doesn't escape strings

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-10-13 18:02:34 Re: pl/perl example in the doc no longer works in 9.1
Previous Message Dimitri Fontaine 2011-10-13 17:05:28 Re: Dumping roles improvements?