| From: | Jun Ishiduka <ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp> |
|---|---|
| To: | masao(dot)fujii(at)gmail(dot)com |
| Cc: | ssinger_pg(at)sympatico(dot)ca, simon(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org, magnus(at)hagander(dot)net, robertmhaas(at)gmail(dot)com, cedric(dot)villemain(dot)debian(at)gmail(dot)com, heikki(dot)linnakangas(at)enterprisedb(dot)com |
| Subject: | Re: Online base backup from the hot-standby |
| Date: | 2011-10-13 05:01:38 |
| Message-ID: | 201110130502.p9D52vaD009464@ccmds32.silk.ntts.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Sorry.
I was not previously able to answer fujii's all comments.
This is the remaining answers.
> + LWLockAcquire(WALInsertLock, LW_EXCLUSIVE);
> + XLogCtl->Insert.fullPageWrites = fullPageWrites;
> + LWLockRelease(WALInsertLock);
>
> I don't think WALInsertLock needs to be hold here because there is no
> concurrently running process which can access Insert.fullPageWrites.
> For example, Insert->currpos and Insert->LogwrtResult are also changed
> without the lock there.
>
Yes.
> The source comment of XLogReportParameters() needs to be modified.
Yes, too.
--------------------------------------------
Jun Ishizuka
NTT Software Corporation
TEL：045-317-7018
E-Mail: ishizuka(dot)jun(at)po(dot)ntts(dot)co(dot)jp
--------------------------------------------
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Brar Piening | 2011-10-13 05:22:40 | Commitfest app not exporting "moved to another commitfest" to rss |
| Previous Message | Jun Ishiduka | 2011-10-13 04:31:27 | Re: Online base backup from the hot-standby |