Re: Bug with pg_ctl -w/wait and config-only directories

Robert Haas wrote:
> On Tue, Oct 4, 2011 at 8:32 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > I still think this is a matter for HEAD only. ?We haven't supported
> > these cases in back branches and so there is little argument for
> > back-patching.
>
> According to Bruce's original post, there is at least one 9.1
> regression here relative to 9.0:
>
> >> What is even worse is that pre-9.1, pg_ctl start would read ports from
> >> the pg_ctl -o command line, but in 9.1 we changed this to force reading
> >> the postmaster.pid file to find the port number and socket directory
> >> location --- meaning, new in PG 9.1, 'pg_ctl -w start' doesn't work for
> >> config-only directories either.

Yes, PG 9.1 pg_ctl -w does this:

$ pg_ctl -w -D tmp start
waiting for server to start....LOG: could not open usermap file
"/usr/var/local/pgdev/pgfoundry/pg_migrator/pg_migrator/tmp/pg_ident.conf":
No such file or directory
LOG: database system was shut down at 2011-10-05 10:53:09 EDT
LOG: database system is ready to accept connections
LOG: autovacuum launcher started
.... stopped waiting
pg_ctl: could not start server
Examine the log output.

This used to work. Of course, there are many non-standard setting that
didn't work in pre-9.1.

I think the real question is whether this issue or allowing pg_upgrade
to work with and old pre-9.2 is worth the backpatching risk. I am
unsure myself.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +