From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Removal of useless include references |
Date: | 2011-08-27 01:16:33 |
Message-ID: | 201108270116.p7R1GXg09828@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera wrote:
> Excerpts from Bruce Momjian's message of vie ago 26 01:35:45 -0300 2011:
> > It has been years since I ran src/tools/pginclude/pgrminclude to remove
> > unnecessary include files. (I have already fixed things so include
> > files can be compiled on their own.)
> >
> > The attached patch removes unneeded include references, and marks some
> > includes as needing to be skipped by pgrminclude.
>
> In btree_gist I think you should remove #include "postgres.h" from the
> .h file and put it in the .c files instead, as is customary. I think
> that would make the other changes incorrect. ltree.h and pg_upgrade.h
> also get this wrong.
Thanks, done.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2011-08-27 01:32:11 | Re: Inputting relative datetimes |
Previous Message | Bruce Momjian | 2011-08-27 00:41:23 | Re: Removal of useless include references |