Re: pgsql: Properly call strerror() in thread test; add comments.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Geoghegan <peter(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Properly call strerror() in thread test; add comments.
Date: 2011-08-22 14:47:22
Message-ID: 201108221447.p7MElM124510@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Peter Geoghegan wrote:
> Why have you removed the GetLastError() call? MSDN says that "The
> return value is the calling thread's last-error code".

True, but we check it also after all the threads have completed setting
their error values. I removed it because Unix does not have such a
check and it seemed logical to do the check only after we were done.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-08-22 14:56:15 pgsql: Fix handling of extension membership when filling in a shell ope
Previous Message User Andrewsn 2011-08-22 14:06:31 ip4r - ip4r: missing file.