| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Kris Jurka <books(at)ejurka(dot)com>, pgsql-hackers(at)postgresql(dot)org, David Fetter <david(at)fetter(dot)org> |
| Subject: | Re: New copyright program |
| Date: | 2011-08-19 23:41:31 |
| Message-ID: | 201108192341.p7JNfVB10290@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan wrote:
>
>
> On 08/19/2011 07:31 PM, Bruce Momjian wrote:
> > Kris Jurka wrote:
> >> Did you also try the "use Tie::File" addition in my fix because your
> >> current coding doesn't work at all. The tie operation is key to actually
> >> writing out the modified copyright notice. Your version just updates the
> >> copyright year in memory, but never gets it back to the file.
> > Ah, that did fix it; thanks. I am attached the updated committed
> > copyright.pl. I also skipped symlinks.
> >
>
> It probably doesn't matter that much in this context, but I should point
> out that Tie::File is not universally available. Some years ago I had to
> revert its use in the buildfarm code for that reason. In general we
> should try to avoid adding extra dependencies wherever possible.
Oh, great. :-(
I can easily change this to rewrite files that contain copyright changes
--- should I?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kris Jurka | 2011-08-19 23:44:04 | Re: New copyright program |
| Previous Message | Andrew Dunstan | 2011-08-19 23:37:29 | Re: New copyright program |