From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | pgAdmin III commit: So, I changed the locale on my setup to "zh_CN.UTF- |
Date: | 2011-05-19 15:45:15 |
Message-ID: | 201105191545.p4JFjFLV016724@gothos.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
So, I changed the locale on my setup to "zh_CN.UTF-8" and tried to restore into a database using a backup from earlier. When I click on "Display objects" tab, I see an error being displayed, although the actual restore happens just fine. Note that no error occurs in English locales.
Took me a while to figure this one out. The issue is with frmRestore::OnEndProcess() function. It naively avoids lines containing ";" or "P" as the first letter. So in the English locale, the last line about the "Process returned exit code 0" is handled. However in other locales, this will be translated and hence the last line will be inspected leading to a spurious error.
The fix is to avoid inspecting the last line.
Branch
------
REL-1_12_0_PATCHES
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=69525eab38f9073a74a46fc42aef32f1d875b6dc
Author: Nikhil S <nixmisc(at)gmail(dot)com>
Modified Files
--------------
pgadmin/frm/frmRestore.cpp | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Nikhil S | 2011-05-20 02:47:15 | Re: Re: pgadmin III - "Display objects" part of database restore errors out in non-English locales |
Previous Message | Dave Page | 2011-05-19 15:44:51 | pgAdmin III commit: So, I changed the locale on my setup to "zh_CN.UTF- |