Re: Patch for pg_upgrade to turn off autovacuum

Bruce Momjian wrote:
> Well, having seen no replies, I am going to apply the version of the
> patch in a few days that keeps the old vacuum-disable behavior for older
> releases, and uses the -b flag for newer ones by testing the catalog
> version, e.g.:
>
> snprintf(cmd, sizeof(cmd),
> SYSTEMQUOTE "\"%s/pg_ctl\" -l \"%s\" -D \"%s\" "
> "-o \"-p %d %s\" start >> \"%s\" 2>&1" SYSTEMQUOTE,
> bindir, output_filename, datadir, port,
> (cluster->controldata.cat_ver >=
> BINARY_UPGRADE_SERVER_FLAG_CAT_VER) ? "-b" :
> "-c autovacuum=off -c autovacuum_freeze_max_age=2000000000",
> log_opts.filename);
>
> I know people like that pg_upgrade doesn't care much about what version
> it is running on, but it is really the ability of pg_upgrade to ignore
> changes made to the server that is really why pg_upgrade is useful, and
> this change makes pg_upgrade even more immune to such changes.

Applied.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +