Re: fn_collation in FmgrInfo considered harmful

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: fn_collation in FmgrInfo considered harmful
Date: 2011-04-12 19:11:24
Message-ID: 201104122111.25457.andres@anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tuesday, April 12, 2011 09:00:40 PM Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On Tuesday, April 12, 2011 08:09:53 PM Tom Lane wrote:
> >> 1. The existing names with a "C" appended (eg, OidFunctionCall2C) will
> >> take a collation argument (in particular, this replaces the existing
> >> DirectFunctionCall1WithCollation and DirectFunctionCall2WithCollation,
> >> which seem a bit verbosely named for my tastes).
> >
> > The first thing I though when I saw OidFunctionCall2C was Function Call
> > with C collation or such and that you wanted to rename all the existing
> > calls to that...
>
> Hm, well, you got a better idea? I definitely want it *short*, because
> these are going to be in a lot of places.
Not really. Maybe DirectFunctionCall1Coll or even DirectFCall1Coll...

Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-04-12 19:41:54 Re: fn_collation in FmgrInfo considered harmful
Previous Message Tom Lane 2011-04-12 19:00:40 Re: fn_collation in FmgrInfo considered harmful