| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, RhodiumToad on IRC <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_upgrade bug found! |
| Date: | 2011-04-07 21:12:51 |
| Message-ID: | 201104072112.p37LCpl26106@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas wrote:
> >> Well, that won't work, because VACUUM can't be executed in a transaction
> >> block or function.
> >
> > Good point.
> >
> > The only bright part of this is that missing clog will throw an error so
> > we are not returning incorrect data, and hopefully people will report
> > problems to us when it happens.
> >
> > Ideally I would like to get this patch and correction code out into the
> > field in case more people run into this problem. ?I know some will, I
> > just don't know how many.
>
> ISTM we need to force a minor release once we are sure this has been
> corrected. We had also probably put out an announcement warning
> people that have already used pg_upgrade of possible data corruption.
> I'm not sure exactly what the language around that should be, but this
> does seem pretty bad.
Yep, "pretty bad" it is.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2011-04-07 21:16:48 | Re: help: collation support on Windows |
| Previous Message | Bruce Momjian | 2011-04-07 21:12:34 | Re: pg_upgrade bug found! |