| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Bug in autovacuum.c? |
| Date: | 2011-03-31 16:17:49 |
| Message-ID: | 201103311617.p2VGHnp15496@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Looking over the autovacuum.c code, I see:
/*
* Determine the oldest datfrozenxid/relfrozenxid that we will allow to
* pass without forcing a vacuum. (This limit can be tightened for
* particular tables, but not loosened.)
*/
recentXid = ReadNewTransactionId();
xidForceLimit = recentXid - autovacuum_freeze_max_age;
/* ensure it's a "normal" XID, else TransactionIdPrecedes misbehaves */
if (xidForceLimit < FirstNormalTransactionId)
xidForceLimit -= FirstNormalTransactionId;
This last line doesn't look right to me; should it be:
xidForceLimit = FirstNormalTransactionId;
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adrian Klaver | 2011-03-31 16:32:14 | Re: [HACKERS] Date conversion using day of week |
| Previous Message | Robert Haas | 2011-03-31 16:14:26 | Re: Problem with pg_upgrade? |