Re: pgsql: Fix doc patch --- pg_options_to_table() returns "setof record".

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix doc patch --- pg_options_to_table() returns "setof record".
Date: 2011-02-26 17:53:27
Message-ID: 201102261753.p1QHrSJ25271@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan wrote:
>
>
> On 02/26/2011 12:27 PM, Bruce Momjian wrote:
> > Fix doc patch --- pg_options_to_table() returns "setof record".
>
> This doesn't strike me as terribly helpful. Why don't we document what
> sort of records it returns, since we know perfectly well?:
>
> andrew=# \df pg_options_to_table
> List of functions
> Schema | Name | Result data type
> | Argument data types | Type
> ------------+---------------------+------------------+-------------------------------------------------------------------+--------
> pg_catalog | pg_options_to_table | SETOF record | options_array
> text[], OUT option_name text, OUT option_value text | normal
> (1 row)

Well, other functions don't mention what they return either so I tried
to be consistent. The mention below does explain their meaning, as does
the text next to it.

Should we fix them all? I thought that column was just for data types.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2011-02-26 18:28:44 Re: pgsql: Fix doc patch --- pg_options_to_table() returns "setof record".
Previous Message Andrew Dunstan 2011-02-26 17:49:07 Re: pgsql: Fix doc patch --- pg_options_to_table() returns "setof record".