From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, PostgreSQL-documentation <pgsql-docs(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: remove tags. |
Date: | 2011-02-07 14:54:46 |
Message-ID: | 201102071454.p17EskV22239@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-docs pgsql-hackers |
Robert Haas wrote:
> On Sun, Feb 6, 2011 at 11:12 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> >> Bruce Momjian wrote:
> >>> remove tags.
> >
> >> Sorry, vague commit message (I forgot squash).
> >
> >> Can I will use git ammend to improve this message?
>
> Absolutely not.
>
> > How about git revert, instead? ?It's not apparent to me that these
> > changes were improvements.
>
> I'll buy that one.
[ CC to docs, committers removed. ]
Well, if we want to revert, then we have to add <literal> to all the
numbers used in our docs --- there was no logic in what we previously
had. Do we want that?
Here is an example line I did not change:
an otherwise idle connection. A value of 0 uses the system default.
Do we want that 0 to appear in a fixed-width font via <literal>?
It is easy to do but we should decide.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2011-02-07 14:58:15 | Re: [COMMITTERS] pgsql: remove tags. |
Previous Message | Itagaki Takahiro | 2011-02-07 07:54:00 | pgsql: Fix a comment for MergeAttributes. |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2011-02-07 14:58:15 | Re: [COMMITTERS] pgsql: remove tags. |
Previous Message | Robert Haas | 2011-02-07 04:58:01 | Re: pgsql: remove tags. |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2011-02-07 14:55:13 | Re: Sync Rep for 2011CF1 |
Previous Message | Robert Haas | 2011-02-07 14:50:09 | Re: A different approach to extension NO USER DATA feature |