Re: pgsql: Use XLOG_BLCKSZ in pg_test_fsync, rather than our own define, bu

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Use XLOG_BLCKSZ in pg_test_fsync, rather than our own define, bu
Date: 2011-01-26 03:19:04
Message-ID: 201101260319.p0Q3J4K03155@momjian.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Sure I am willing to fix it. Should I have it always use the value of
> > XLOG_BLCKSZ for its tests, and adjust the output text accordingly?
>
> Makes sense to me.

OK, done with attached patch. I also cleaned up the open_sync size test
output. The patch was easy. Thanks for the ideas.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

Attachment Content-Type Size
/rtmp/fsync.diff text/x-diff 2.9 KB

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2011-01-26 03:21:11 pgsql: Adjust pg_test_fsync to always do XLOG_BLCKSZ-sized writes, rath
Previous Message Tom Lane 2011-01-26 03:06:26 Re: pgsql: Use XLOG_BLCKSZ in pg_test_fsync, rather than our own define, bu