From: | David Fetter <david(at)fetter(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files. |
Date: | 2010-11-29 21:14:54 |
Message-ID: | 20101129211454.GF17835@fetter.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Mon, Nov 29, 2010 at 02:09:29PM -0500, Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > On Mon, Nov 29, 2010 at 16:26, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> >> That works for me. But should we make a practice of writing the
> >> ENTIRE SHA-ID rather than an abbreviated form, so that we could more
> >> easily replace 'em later if need be?
>
> > I think that's a good idea.
>
> Just as a data point, there is already one 7-hex-digit collision in our
> repository:
>
> Branch: master Release: REL6_1 [aaeef4dae] 1997-04-09 08:29:35 +0000
> Branch: master Release: REL6_1 [aaeef4d17] 1996-11-10 03:06:38 +0000
>
> I think it's quite foolish to depend on abbreviated hashes to be unique
> forever.
Good point. While a full-hash collision is of course possible, we
have much more likely things that can mess us up than that :)
Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
From | Date | Subject | |
---|---|---|---|
Next Message | User Itagaki | 2010-11-30 12:10:24 | pgbulkload - pgbulkload: Add MSVC configurations for 9.0, 8.4, and 8.3. |
Previous Message | Tom Lane | 2010-11-29 19:09:29 | Re: Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files. |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-11-29 21:33:19 | Re: improving foreign key locks |
Previous Message | Alvaro Herrera | 2010-11-29 21:12:56 | Re: improving foreign key locks |