Re: pgsql: Speed up conversion of signed integers to C strings.

Robert Haas wrote:
> On Sat, Nov 20, 2010 at 5:23 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> >> Ugh. ?I made an attempt at a fix to both of these issues, but I'm not
> >> totally sure I got it right, and I'm too tired to stay up any later to
> >> see what happens. ?I'll check the BF in the morning.
> >
> > If you change a test that has alternative result files, you need to change
> > all the result files. See src/test/regress/resultmap.
> >
> > In this case you missed out changing int8-exp-three-digits.out - see
> > <http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=dawn_bat&dt=2010-11-20%2005%3A30%3A07>
>
> Sorry, I always forget about the alternate expected output files,
> because they never seem to be the ones that my platform needs.
>
> Ah, the joy of debugging by buildfarm. Nothing better than having the
> whole world watch your mistakes in painstaking detail!

Yes, in a way when you commit a patch you become a slave of the
buildfarm. I can say that with experience based on the recent patches I
have written.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +