From: | David Fetter <david(at)fetter(dot)org> |
---|---|
To: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
Cc: | PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Tab completion for view triggers in psql |
Date: | 2010-10-29 15:33:00 |
Message-ID: | 20101029153300.GA14005@fetter.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Oct 26, 2010 at 11:55:07AM +0900, Itagaki Takahiro wrote:
> On Tue, Oct 26, 2010 at 11:34 AM, David Fetter <david(at)fetter(dot)org> wrote:
> >> Do we need to 'add' it?
> > Possibly. My understanding is that it couldn't really replace it.
>
> Ah, I see. I was wrong. We can have modification privileges for
> views even if they have no INSTEAD OF triggers.
Right.
> So, I think your original patch is the best solution. We could use
> has_table_privilege() additionally, but we need to consider any
> other places if we use it. For example, DROP privileges, etc.
That seems like a matter for a separate patch. Looking this over, I
found I'd created a query that can never get used, so please find
enclosed the next version of the patch :)
Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
Attachment | Content-Type | Size |
---|---|---|
psql_view_trigger_tab_completion_3.diff | text/plain | 10.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2010-10-29 15:40:47 | Re: crash in plancache with subtransactions |
Previous Message | Tom Lane | 2010-10-29 15:23:38 | Re: plan time of MASSIVE partitioning ... |