| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Cc: | David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w |
| Date: | 2010-09-26 10:36:47 |
| Message-ID: | 201009261236.48805.andres@anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sunday 26 September 2010 02:29:16 David Fetter wrote:
> On Sat, Sep 25, 2010 at 11:04:28PM +0000, Tom Lane wrote:
> > Fix another join removal bug: the check on PlaceHolderVars was
> > wrong.
> >
> > The previous coding would decide that join removal was unsafe upon
> > finding a PlaceHolderVar that needed to be evaluated at the inner
> > rel and then used above the join. However, this fails to cover the
> > case of PlaceHolderVars that refer to both the inner rel and some
> > other rels. Per bug report from Andrus.
>
> The person who found it originally was Kirill (xitology) Simonov. He
> brought it up in IRC. :)
No, thats a different bug... For one its affecting 8.4 at least as well, for
another its not yet fixed ;-)
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2010-09-26 11:42:05 | pgsql: Add ALTER TYPE ... ADD/DROP/ALTER/RENAME ATTRIBUTE |
| Previous Message | Tom Lane | 2010-09-26 05:51:32 | pgsql: Still more tweaking of git_changelog. |