From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
---|---|
To: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | pgAdmin III commit: Fix connection color on the query tool |
Date: | 2010-09-25 07:03:59 |
Message-ID: | 201009250703.o8P73xCn086124@gothos.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Fix connection color on the query tool
The color used the old connection informations. In fact, we call two times the
OnChangeConnection() method. First time to choose another connection and add
the new one to the combobox, and another time to really change the connection.
IOW, we change the colors despite the fact we actually didn't change the
connection. So we can't check the connection with the connection global
variable. We need to give the connection local variable to the
GetServerColour() method. So, this method gets a connection parameter.
Report from Valentine Gogichashvili.
Fixed #241.
Branch
------
REL-1_12_0_PATCHES
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=787c56bba8124f79d2d1a16e5348e103aec89d78
Modified Files
--------------
pgadmin/frm/frmQuery.cpp | 10 +++++-----
pgadmin/include/frm/frmQuery.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | pgAdmin Trac | 2010-09-25 07:05:54 | Re: [pgAdmin III] #241: Connection color is not correctly changed in query windows connection drop-down |
Previous Message | pgAdmin Trac | 2010-09-25 06:51:01 | [pgAdmin III] #241: Connection color is not correctly changed in query windows connection drop-down |