From: | Quan Zongliang <quanzongliang(at)gmail(dot)com> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, David Fetter <david(at)fetter(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Fw: patch for pg_ctl.c to add windows service start-type |
Date: | 2010-08-22 14:03:32 |
Message-ID: | 20100822220332.6688a11c.quanzongliang@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Sure, I agree.
New patch attached. How about this?
On Fri, 20 Aug 2010 11:21:18 +0200
Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Fri, Aug 20, 2010 at 01:01, Quan Zongliang <quanzongliang(at)gmail(dot)com> wrote:
> > Because Windows's CreateService has serial start-type:
> > SERVICE_AUTO_START
> > SERVICE_BOOT_START
> > SERVICE_DEMAND_START
> > SERVICE_DISABLED
> > SERVICE_SYSTEM_START
> >
> > Although all of them are not useful for pg service.
> > I think it is better to use enum.
>
> I don't see us ever using anything other than auto or demand. The
> others aren't for "regular services", except for "disabled". And
> adding a disabled service makes no sense :-) So I'm with Alvaro, I
> think it's a good idea to simplify that.
>
>
> --
> Magnus Hagander
> Me: http://www.hagander.net/
> Work: http://www.redpill-linpro.com/
--
Quan Zongliang <quanzongliang(at)gmail(dot)com>
Attachment | Content-Type | Size |
---|---|---|
pg_ctl.diff | text/plain | 3.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2010-08-22 14:04:09 | Re: Return of the Solaris vacuum polling problem -- anyone remember this? |
Previous Message | KaiGai Kohei | 2010-08-22 12:38:43 | Re: security hook on authorization |