Re: Fw: patch for pg_ctl.c to add windows service start-type

From: Quan Zongliang <quanzongliang(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: David Fetter <david(at)fetter(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fw: patch for pg_ctl.c to add windows service start-type
Date: 2010-08-19 23:01:54
Message-ID: 20100820070154.7096ab15.quanzongliang@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Because Windows's CreateService has serial start-type:
SERVICE_AUTO_START
SERVICE_BOOT_START
SERVICE_DEMAND_START
SERVICE_DISABLED
SERVICE_SYSTEM_START

Although all of them are not useful for pg service.
I think it is better to use enum.

On Thu, 19 Aug 2010 16:48:53 -0400
Alvaro Herrera <alvherre(at)commandprompt(dot)com> wrote:

> Excerpts from David Fetter's message of jue ago 19 16:40:18 -0400 2010:
> > On Thu, Aug 19, 2010 at 03:47:43PM -0400, Alvaro Herrera wrote:
> > > Excerpts from David Fetter's message of jue ago 19 11:48:53 -0400 2010:
> > >
> > > > + <varlistentry>
> > > > + <term><option>-S <replaceable class="parameter"></replaceable></option></term>
> > >
> > > You omitted the start-type inside the <replaceable> tag. Also, the "a"
> > > and "d" values seem to be accepted but not documented.
> >
> > D'oh! Changed patch enclosed. Now in context format :)
>
> Thanks.
>
> Another thing -- why is there an enum at all? Seems it'd be
> simpler to assign the right value to the variable in the getopt() code
> to start with.
>
> --
> Álvaro Herrera <alvherre(at)commandprompt(dot)com>
> The PostgreSQL Company - Command Prompt, Inc.
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support

--
Quan Zongliang <quanzongliang(at)gmail(dot)com>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Quan Zongliang 2010-08-19 23:04:13 Re: Fw: patch for pg_ctl.c to add windows service start-type
Previous Message Steven Schlansker 2010-08-19 22:54:36 Re: COPY FROM/TO losing a single byte of a multibyte UTF-8 sequence