From: | David Fetter <david(at)fetter(dot)org> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: proposal: tuplestore, tuplesort aggregate functions |
Date: | 2010-08-19 13:46:28 |
Message-ID: | 20100819134628.GA14259@fetter.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Aug 19, 2010 at 12:45:13PM +0200, Pavel Stehule wrote:
> Hello
>
> > I'll test both variant first. Maybe there are not any significant
> > difference between them. Now nodeAgg can build, fill a tuplesort.
> > So I think is natural use it. It needs only one - skip a calling a
> > transident function and directly call final function with external
> > tuplesort. Minimally you don't need 2x same code.
>
> yesterday I did a small test. Aggregates without transident
> functions are only about 2% faster, so there has no sense thinking
> more about them. I'll send a patch with median and percentile
> functions immediately - these functions are implemented like usual
> aggregates.
NTILE is already a windowing function. Might want to check into any
performance improvements you can give that.
As to median, please make sure you say in detail which median you're
using and name it so, as there is no single, authoritative median.
Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-08-19 13:47:17 | Re: Re: [COMMITTERS] pgsql: Coerce 'unknown' type parameters to the right type in the |
Previous Message | Tom Lane | 2010-08-19 13:38:02 | Re: CommitFest 2009-07: Yay, Kevin! Thanks, reviewers! |