pgsql: Fix pg_restore to complain if any arguments remain after parsing

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix pg_restore to complain if any arguments remain after parsing
Date: 2010-08-13 14:38:13
Message-ID: 20100813143813.21F877541D7@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix pg_restore to complain if any arguments remain after parsing the switches
and input file name, per bug #5617 from Leo Shklovskii. Rearrange the
corresponding code in pg_dump and pg_dumpall so that all three programs
handle this in a consistent, straightforward fashion.

Back-patch to 9.0, but no further. Although this is certainly a bug, it's
possible that people have scripts that will be broken by the added error
check, so it seems better not to change the behavior in stable branches.

Tags:
----
REL9_0_STABLE

Modified Files:
--------------
pgsql/src/bin/pg_dump:
pg_dump.c (r1.581.2.1 -> r1.581.2.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c?r1=1.581.2.1&r2=1.581.2.2)
pg_dumpall.c (r1.134 -> r1.134.4.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dumpall.c?r1=1.134&r2=1.134.4.1)
pg_restore.c (r1.102 -> r1.102.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_restore.c?r1=1.102&r2=1.102.2.1)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-08-13 15:42:21 pgsql: Make RecordTransactionCommit() respect wal_level.
Previous Message Tom Lane 2010-08-13 14:38:04 pgsql: Fix pg_restore to complain if any arguments remain after parsing