From: | tgl(at)postgresql(dot)org (Tom Lane) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix incorrect logic in plpgsql for cleanup after evaluation of |
Date: | 2010-08-09 18:51:02 |
Message-ID: | 20100809185102.ABB5D7541D7@cvs.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
Fix incorrect logic in plpgsql for cleanup after evaluation of non-simple
expressions. We need to deal with this when handling subscripts in an array
assignment, and also when catching an exception. In an Assert-enabled build
these omissions led to Assert failures, but I think in a normal build the
only consequence would be short-term memory leakage; which may explain why
this wasn't reported from the field long ago.
Back-patch to all supported versions. 7.4 doesn't have exceptions, but
otherwise these bugs go all the way back.
Heikki Linnakangas and Tom Lane
Tags:
----
REL8_0_STABLE
Modified Files:
--------------
pgsql/src/pl/plpgsql/src:
pl_exec.c (r1.127.4.9 -> r1.127.4.10)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_exec.c?r1=1.127.4.9&r2=1.127.4.10)
pgsql/src/test/regress/expected:
plpgsql.out (r1.24.4.1 -> r1.24.4.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/plpgsql.out?r1=1.24.4.1&r2=1.24.4.2)
pgsql/src/test/regress/sql:
plpgsql.sql (r1.19.4.1 -> r1.19.4.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/plpgsql.sql?r1=1.19.4.1&r2=1.19.4.2)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-08-09 18:51:12 | pgsql: Fix incorrect logic in plpgsql for cleanup after evaluation of |
Previous Message | Tom Lane | 2010-08-09 18:50:54 | pgsql: Fix incorrect logic in plpgsql for cleanup after evaluation of |