From: | tgl(at)postgresql(dot)org (Tom Lane) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix incorrect logic in plpgsql for cleanup after evaluation of |
Date: | 2010-08-09 18:50:11 |
Message-ID: | 20100809185011.B20077541D7@cvs.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
Fix incorrect logic in plpgsql for cleanup after evaluation of non-simple
expressions. We need to deal with this when handling subscripts in an array
assignment, and also when catching an exception. In an Assert-enabled build
these omissions led to Assert failures, but I think in a normal build the
only consequence would be short-term memory leakage; which may explain why
this wasn't reported from the field long ago.
Back-patch to all supported versions. 7.4 doesn't have exceptions, but
otherwise these bugs go all the way back.
Heikki Linnakangas and Tom Lane
Modified Files:
--------------
pgsql/src/pl/plpgsql/src:
pl_exec.c (r1.262 -> r1.263)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_exec.c?r1=1.262&r2=1.263)
pgsql/src/test/regress/expected:
plpgsql.out (r1.87 -> r1.88)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/plpgsql.out?r1=1.87&r2=1.88)
pgsql/src/test/regress/sql:
plpgsql.sql (r1.73 -> r1.74)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/plpgsql.sql?r1=1.73&r2=1.74)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-08-09 18:50:20 | pgsql: Fix incorrect logic in plpgsql for cleanup after evaluation of |
Previous Message | Robert Haas | 2010-08-09 14:52:51 | Re: pgsql: Provide stable target anchors for libpq functions. |