pgsql: Fix core dump in QTNodeCompare when tsquery_cmp() is applied to

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix core dump in QTNodeCompare when tsquery_cmp() is applied to
Date: 2010-08-03 00:10:39
Message-ID: 20100803001039.857587541D7@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix core dump in QTNodeCompare when tsquery_cmp() is applied to two empty
tsqueries. CompareTSQ has to have a guard for the case rather than blindly
applying QTNodeCompare to random data past the end of the datums. Also,
change QTNodeCompare to be a little less trusting: use an actual test rather
than just Assert'ing that the input is sane. Problem encountered while
investigating another issue (I saw a core dump in autoanalyze on a table
containing multiple empty tsquery values).

Back-patch to all branches with tsquery support.

In HEAD, also fix some bizarre (though not outright wrong) coding in
tsq_mcontains().

Modified Files:
--------------
pgsql/src/backend/utils/adt:
tsquery_op.c (r1.8 -> r1.9)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/tsquery_op.c?r1=1.8&r2=1.9)
tsquery_util.c (r1.13 -> r1.14)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/tsquery_util.c?r1=1.13&r2=1.14)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-08-03 00:10:45 pgsql: Fix core dump in QTNodeCompare when tsquery_cmp() is applied to
Previous Message Robert Haas 2010-08-02 23:20:23 pgsql: Teach levenshtein() about multi-byte characters.